Re: [PATCH 2/3] Btrfs: use wrapper page_offset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -	u64 start = (u64)page->index << PAGE_CACHE_SHIFT;
> +	u64 start = (u64)page_offset(page);

The (u64) cast was presumably to keep from losing high bits during the
shift.  page_offset() already has that cast internally and returns
loff_t, which is always long long.  I think that you can drop the cast
from all these calls.

> -		start = ((u64)page->index << PAGE_CACHE_SHIFT) +
> +		start = ((u64)page_offset(page)) +
>  			bvec->bv_offset;

And you can fix the line break now that the line will be nice and short.

And the parenthesis can be removed.

- z
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux