Hi Stefan, great work. However I have a suggestion: what about putting all the command under 'device' sub commands: something like: - btrfs device replace <old> <new> </path> - btrfs device status </path> Where "btrfs device status" would show only the status of the "replacing" operation; but in the future it could show also the status of the "delete" command (which it is the only other "device sub-command" which needs time to complete). Of course I am not asking to complete the "btrfs device status" part for the "btrfs device delete" command. This could be implemented in a second time. I think that so "replace" would be the natral extension to the "add" and "delete" subcommands. BR G.Baroncelli On Wed, Nov 7, 2012 at 2:12 PM, Stefan Behrens <sbehrens@xxxxxxxxxxxxxxxx> wrote: > On Wed, 07 Nov 2012 11:14:36 +0900, Tsutomu Itoh wrote: >> (2012/11/07 1:38), Stefan Behrens wrote: >>> replace start [-Bfr] <path> <srcdev>|<devid> <targetdev> >> >> I think that >> "btrfs replace start [-Bfr] <srcdev>|<devid> <targetdev> <path>" >> of the same synopsis as other subcommands is better. > > You are right. 'btrfs device add' and 'btrfs device delete' have the > path at the end and the device in front, and there is no good reason to > not make it look equally. I will change it accordingly and post a V2 of > the Btrfs-progs patch within the next few days. > > Thanks! > > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
