On 11/06/2012 19:17, Bart Noordervliet wrote:
Great new feature Stefan, thanks a lot! Going to give it a spin right
away. While compiling I got this (probably superfluous) error that you
might want to prevent:
fs/btrfs/dev-replace.c: In function ‘btrfs_dev_replace_start’:
fs/btrfs/dev-replace.c:344:5: warning: ‘ret’ may be used uninitialized
in this function [-Wmaybe-uninitialized]
Regards,
Bart
Yes, this happens on 32 bit builds, not on 64 bit builds. If you look at
the source code, the compiler is obviously wrong (or I am blind).
ret = btrfs_dev_replace_find_srcdev(root, args->start.srcdevid,
args->start.srcdev_name,
&src_device);
mutex_unlock(&fs_info->volume_mutex);
if (ret) { <-- this is line 344
But thanks for the feedback anyway!
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
