Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Mittwoch, 3. Oktober 2012 schrieb Ilya Dryomov:
> > $ ./btrfs filesystem df /
> > Path: /
> >
> > Summary:
> >   Disk_size:                 72.57GB
> >   Disk_allocated:            25.10GB
> >   Disk_unallocated:          47.48GB
> >   Logical_size:              23.06GB
> >   Used:                      11.01GB
> >   Free_(Estimated):          55.66GB    (Max: 59.52GB, Min: 35.78GB)
> >   Data_to_disk_ratio:           92 %
> > 
> >
> > Details:

How about calling this "Chunks:"?

Its actually what is being displayed.

> >   Chunk-type  Mode      Chunk-size Logical-size        Used
> 
> "Type" for the first column is probably enough.

Then Chunk-type can become "Type"...

> Why is the third column called Chunk-size?  If my understanding is
> correct, it's just a break down of Disk_allocated from the summary
> section.  If so, why not call it Disk_allocated to avoid confusion?

... and "Chunk-size" just "Size".

> Also, why do you use dashes instead of underbars for table headers?

I prefer dashes, or even spaces, but spaces are more difficult to parse.

So or so I think scripts better do not parse a user formatted output – it 
sets the output format thats intended for the users viewing pleasure in 
stone. Then its better to provide an option to get all of this in 
parseable format. fio 2.0.10 has a JSON outputter for easy parsing, maybe 
some of that can be used – in a different patch set.

Ciao,
-- 
Martin 'Helios' Steigerwald - http://www.Lichtvoll.de
GPG: 03B0 0D6C 0040 0710 4AFA  B82F 991B EAAC A599 84C7
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux