Re: [PATCH] Btrfs: try to avoid doing a search in btrfs_next_leaf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 03, 2012 at 06:57:26AM -0600, Alex Lyakas wrote:
> Hi Josef,
> in send code, in full_send_tree() there is code like this:
>                 key.objectid = found_key.objectid;
>                 key.type = found_key.type;
>                 key.offset = found_key.offset + 1;
> 
>                 ret = btrfs_next_item(send_root, path);
>                 if (ret < 0)
>                         goto out;
>                 if (ret) {
>                         ret  = 0;
>                         break;
> 
> It wants to jump to the next greater key in the tree, whatever
> objectid it has (the reason is that here we need to traverse the whole
> file tree). I believe with your change it might get broken... What do
> you think?

Yeah you are right, I'll hold off on this for now.  Thanks,

Josef 
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux