Hi,
Thanks for this patch.
Personally, i don't mind any of the propositions as the developpement
is still in progress and may be adapted.
Furthermore, as Roman said, df is more well known for unix users.
Thanks to your work on that, i've started developing a bunch of
scripts for monitoring btrfs disk usage (and also for monitoring
snapper if anyone use it) through nagios.
Regards.
Sébastien
Roman Mamedov <rm@xxxxxxxxxx> a écrit :
On Wed, 3 Oct 2012 08:22:06 +0200
Goffredo Baroncelli <kreijack@xxxxxxxxx> wrote:
On Wed, Oct 3, 2012 at 1:46 AM, Chris Mason
<chris.mason@xxxxxxxxxxxx> wrote:
[...]
> I like it, thanks. Could you please update btrfs fi df to show this
> instead of adding a new command though?
Hi Chris,
no problem to update the patches, however I have one suggestion:
- leave "btrfs fi df" as is to no break any script (if any) which
would uses it. Hide it from the help and deprecating it in the man
page. This because the output is very different.
- renaming "btrfs fi disk-usage" in "btrfs fi disk-free", which make sense.
1) btrfs is still labeled experimental, so no script author should have
seriously relied on utilities text output to stay unchanged long-term;
personally I don't see modifying it (especially not in some superficial way,
but as a part of major improvement) to be a problem;
2) "disk-usage" and "disk-free" are both way too awkward and too
long to type,
compared to "fi df", and "df" is the expected shorthand for "disk
free" in the
UNIX land.
--
With respect,
Roman
~~~~~~~~~~~~~~~~~~~~~~~~~~~
"Stallman had a printer,
with code he could not see.
So he began to tinker,
and set the software free."
----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
