On Mon, Sep 24, 2012 at 09:40:00PM +0800, Wei Yongjun wrote: > >> dpatch engine is used to auto generated this patch. > >> (https://github.com/weiyj/dpatch) > > I've played with it, looks nice, although it's full of hardcoded paths. > > Yes, it is current hardcoded path, because I used the linux.git and > linux-next.git, and dpatch will update the git tree every day. > After login, you can change the git url in the web. Sure, I was able to point the git source to my local linux.git. > > I'd like to run it directly from the git repo. Can you please fix that? > > No patch from me, because I hadcoded my paths :) > > Do you mean does not need auto update git repo, only scan the > change under your git repo? I'm talking about hardcoded paths for the scripts in bin/ like dpatch/views/engine.py: args = '/usr/dpatch/bin/importcocci.sh %s' % fname or dpatch/models.py: return '/var/lib/dpatch/repo/' + dname Not to say that '/usr/' is not the right place for adding new per-package subdirs, refer to http://www.pathname.com/fhs/pub/fhs-2.3.html#THEUSRHIERARCHY . (Also the database has hardcoded path into /var/lib/dpatch) > > It would be great if we can run a set of .cocci scripts that would > > verify code invariants (limited to cocci capabilities, but eg. the > > IS_ERR is a good example) and add new ones eventually over time. > > By default, It does not include cocci scripts, only include dup include, > useless 'linux/version.h' check engine, and is disabled. No problem that the .cocci scripts are not there, I'm fine with adding them manually now, just to test the tool, but all the hardcoded paths didn't let me do that :) david -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
