Re: [PATCH 4/4] Btrfs: tivial cleanup: add space between = and the rest code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 24, 2012 at 08:47:33AM +0800, Wang Sheng-Hui wrote:
> trivial code cleanup.

> -			ret =btrfs_drop_snapshot(root, NULL, 1, 0);
> +			ret = btrfs_drop_snapshot(root, NULL, 1, 0);

Sorry but this is too trivial.

Unless it really bugs you when you're going through code, I don't think
that cleanups at this level are necessary. Reading through commit
history of some code via 'git blame' and seeing such cleanups is not
welcome.

I have a patchet in testing that updates a few things around snapshot
cleaning and this line will get fixed, so it'll not stay forever.

david
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux