Re: [PATCH V3 4/7] Btrfs-progs: fix wrong way to check if the root item contains otime and uuid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 18 Sep 2012 13:56:44 +0800, Anand Jain wrote:
> 
> 
>> -                if(ri->generation == ri->generation_v2) {
>> +                if(sh->len == sizeof(struct btrfs_root_item)) {
>>                       t = ri->otime.sec;
> 
>  This looks fine now but should this work when we
>  move to v3 and still have access to v2 introduced
>  members.?
> 
>  ker cli
>  v3  v2  v2 introduced members are unnecessarily blocked
>  v2  v3  --as above--

No.

I will update my patch to fix this problem.

Thanks
Miao
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux