On Fri, Jun 15, 2012 at 05:27:49PM +0300, Andrei Popa wrote: > On Fri, 2012-06-15 at 12:50 +0200, David Sterba wrote: > > mount -o compress,nocompress /dev /mnt > > > > Is it on or off? Yeah we can document that nocompress has higher > > priority. But then I can't turn a nocompress option back to compress via > > remount. This is possible with Arnd's patch. > > This happens for space_cache mount option: > ierdnac-hp ~ # mount -o remount,space_cache,nospace_cache /mnt/btrfs/ > > Also there are mount option that can't be enabled/disabled by remount > like: > nobarrier - > "barrier" mount option doesn't exists > ssd -> "nossd" doesn't exists > noacl, user_subvol_rm_allowed, autodefrag, inode_cache, check_int, > check_int_data. I'm not against having options with a simple 'no' prefix, but it seems more fit for a "on/off" type of options, like ssd/nossd. The compression takes more values. > For some of these(ex: nossd,barrier) I think it would be usefull to have > the reverse action. > What do you think ? The style of mount options seems to * have sane defaults * not listed in mount options * have reverting counterparts (when applicable) These are more recommendations than some hard rules, as eg. space_cache is default, but listed in mount options, and I don't find this harmful. david -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
