Re: [PATCH] Btrfs: add "nocompress" mount option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 15, 2012 at 06:56:35PM +0200, Goffredo Baroncelli wrote:
> On 06/15/2012 12:50 PM, David Sterba wrote:
> > I prefer this over adding an extra option to disable. This
> > way there's no confusion if the compression is on or off.
> > 
> >   mount -o compress,nocompress /dev /mnt
> 
> The confusion still exists if an user does:
> 
> 	mount -o compress,compress=no /dev /mnt

Ah right. The precedence is simply given by order on the options line,
and this is same in case of 'nocompress'.

> However I prefer the form "compress=" because already exists the option
> "compress=lzo|zlib".

My comment about precedence is not valid now and the (rather small)
benefit of having a single option is to have the code handling this in a
single location.


david
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux