Re: [PATCH 1/4] Btrfs: use radix tree for checksum

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




+    BUG_ON(ret);

I wonder if we can patch BUG_ON() to break the build if its only
argument is "ret".


why?

Well, I'm mostly joking :).  That would be a very silly change to make.

But only mostly joking.  btrfs does have a real fragility problem from
all these incomplete error handling paths:

	$ grep 'BUG_ON(ret.*)' fs/btrfs/*.c | wc -l
	197

We should be fixing these, not adding more.  I don't think any patches
should be merged which add more of these.

- z
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux