On Thu, Jun 14, 2012 at 04:23:17PM +0800, Liu Bo wrote:
> chattr only uses FS_COMPR_FL to switch on/off the compression flag,
> so we don't need these FS_NOCOMP_FL checks.
Please drop this patch. The FS_NOCOMP_FL has a different meaning, it
forces the filesystem to completely avoid compression of the file.
FS_COMPR_FL tells the fs to compress the file, even if the filesystem is
not mounted with compression.
And none of the two flags means 'let the fs pick according to current
defaults', ie when the fs is moutned with compression (or not).
As a user, I have a fine grained control over the per-file compression
status.
We need to chattr/lsattr to support the existing NOCOMP flag, I'd like
to see a letter 'Z' assigned for it, but it's currently occupied by
{ FS_DIRTY_FL, 'Z', "Compressed_Dirty_File" }
(though I'm not sure if the compression-related flags are actually used
at all around the extN filesystems). Maybe 'z' is a good choice here as
well, I don't mind.
david
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
