On 06/14/2012 12:07 AM, Zach Brown wrote:
>
>> int set_state_private(struct extent_io_tree *tree, u64 start, u64
>> private)
>> {
> [...]
>> + ret = radix_tree_insert(&tree->csum, (unsigned long)start,
>> + (void *)((unsigned long)private<< 1));
>
> Will this fail for 64bit files on 32bit hosts?
In theory it will fail, but crc32c return u32, so private will be originally u32,
and it'd be ok on 32bit hosts.
>
>> + BUG_ON(ret);
>
> I wonder if we can patch BUG_ON() to break the build if its only
> argument is "ret".
>
why?
thanks,
liubo
> - z
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
