Re: [PATCH v2 0/5] Allow for quick removing of btrfs signature from block device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 01 of May 2012 14:43:37 Tomasz Torcz wrote:
> On Tue, May 01, 2012 at 02:38:01PM +0200, Hubert Kario wrote:
> > This patch series adds `btrfs device zero super <dev>` command to remove
> > the btrfs signature from the device as well as fix few minor problems in
> > btrfs_prepare_device function.
> 
>   Shouldn't you rather extend “wipefs” from util-linux?

wipefs v.2.21.1 does detect btrfs so there's no need to.

I'd guess that most people will be thinking about btrfs RAID management in LVM 
or MD terms, so the zero-superblock option should be available in the btrfs 
tool proper (as similar option is avaiable in mdadm).

Adding it is trivial (look at my V1 patch) and does not introduce special 
code.

What's more, wipefs demages only the first superblock (so the fs is still 
mountable using btrfs-select-super -s 1 <dev>), while btrfs device zero-
superblock removes all superblocks.

Regards,
-- 
Hubert Kario
QBS - Quality Business Software
02-656 Warszawa, ul. Ksawerów 30/85
tel. +48 (22) 646-61-51, 646-74-24
www.qbs.com.pl
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux