On Thu, Apr 12, 2012 at 12:11:13PM -0400, Chris Mason wrote: > On Wed, Apr 11, 2012 at 03:11:46PM +0200, Jan Schmidt wrote: > > Hi Jeff, > > > > > >> An alternative solution to dealing with collisions could be to > > >> emulate the dir-item insertion code - specifically something like > > >> insert_with_overflow() which will stuff multiple items under one > > >> key. I tend to prefer the idea of > > > > > > I vote for this option. > > [ Big patch series, thanks Mark! ] > > I prefer the insert_with_overflow because it makes the deletion case > less complex. If we handle collisions with bits in the offset, we have > to search around in the tree to find the key that was actually used to > insert the item. > > The insert_with_overflow code uses just one key, at the cost of having > to search around inside the item. Yeah this actually turns out to be a bit easier to code as well. I'm taking this approach. --Mark -- Mark Fasheh -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
