Re: [patch 35/35] btrfs: disallow unequal data/metadata blocksize for mixed block groups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 22, 2012 at 05:02:24PM +0100, Stefan Behrens wrote:
> > --- a/fs/btrfs/disk-io.c
> > +++ b/fs/btrfs/disk-io.c
> > @@ -2302,6 +2302,14 @@ int open_ctree(struct super_block *sb,
> >  		goto fail_sb_buffer;
> >  	}
> >  
> > +	if ((features & BTRFS_FEATURE_INCOMPAT_MIXED_GROUPS) &&
> > +			(leafsize != nodesize && sectorsize != nodesize)) {
> 
> Dave, Shouldn't this be like this (you want all three sizes to be equal
> in mixed mode, don't you?):
> 	if ((features & BTRFS_FEATURE_INCOMPAT_MIXED_GROUPS) &&
> 			(leafsize != nodesize || sectorsize != nodesize)) {

Yes, you're right, thanks for catching it.


david
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux