On Tue, Dec 13, 2011 at 02:03:14PM -0500, Phillip Susi wrote: > On 12/13/2011 12:55 PM, Josef Bacik wrote: > >I've been hitting this BUG_ON() in btrfs_orphan_add when running xfstest 269 in > >a loop. This is because we will add an orphan item, do the truncate, the > >truncate will fail for whatever reason (*cough*ENOSPC*cough*) and then we're > >left with an orphan item still in the fs. Then we come back later to do another > >truncate and it blows up because we already have an orphan item. This is ok so > >just fix the BUG_ON() to only BUG() if ret is not EEXIST. Thanks, > > Wouldn't it be better to fix the underlying bug, and remove the > orphan item when the truncate fails? > No because we still need the thing to be cleaned up. If the truncate fails we need to leave the orphan item there so the next time the fs is mounted the inode is cleaned up, that's not a bug. Thanks, Josef -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
