Re: [PATCH] Btrfs: protect orphan block rsv with spin_lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 05, 2011 at 12:50:39PM +0100, Christian Brunner wrote:
> 2011/12/2 Josef Bacik <josef@xxxxxxxxxx>:
> > We've been seeing warnings coming out of the orphan commit stuff forever from
> > ceph.  Turns out it's because we're racing with checking if the orphan block
> > reserve is set, because we clear it outside of the spin_lock.  So leave the
> > normal fastpath checks where they are, but take the spin_lock and _recheck_ to
> > make sure we haven't had an orphan block rsv added in the meantime.  Then clear
> > the root's orphan block rsv and release the lock.  With this patch a user said
> > the warnings went away and they usually showed up pretty soon after he started
> > ceph.  Thanks,
> 
> *sigh* - As soon as I turned my back to the serve console it also
> happened again on one of our nodes. That was 25 hours after I started
> the system. Usually I see these warnings a few minutes after the
> start, but the have been cases in the past where it took longer. So
> I'm not sure if the improvement is due to the patch.
> 
> Josef: I was still running the patch you sent me, but there was no
> message from the printk's you added.
> 

:( ok I'll try again.  Thanks,

Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux