Re: [patch 65/99] btrfs: ->submit_bio_hook error push-up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 23, 2011 at 07:36:38PM -0500, Jeff Mahoney wrote:
> --- a/fs/btrfs/extent_io.c
> +++ b/fs/btrfs/extent_io.c
> @@ -2752,10 +2759,12 @@ retry:
>  static void flush_epd_write_bio(struct extent_page_data *epd)
>  {
>  	if (epd->bio) {
> +		int ret;
>  		if (epd->sync_io)
> -			submit_one_bio(WRITE_SYNC, epd->bio, 0, 0);
> +			ret = submit_one_bio(WRITE_SYNC, epd->bio, 0, 0);
>  		else
> -			submit_one_bio(WRITE, epd->bio, 0, 0);
> +			ret = submit_one_bio(WRITE, epd->bio, 0, 0);
> +		BUG_ON(ret < 0);

this if/else could be transfomed in the same way as in

"63/99 btrfs: Simplify btrfs_submit_bio_hook"

int rw = WRITE;

if (epd->sync_io)
	rw = WRITE_SYNC;

ret = submit_one_bio(rw, ...);
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux