Re: [PATCH] Btrfs-progs: mention libattr dependency in INSTALL file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 02, 2011 at 05:14:33PM +0200, Ilya Dryomov wrote:
> Signed-off-by: Ilya Dryomov <idryomov@xxxxxxxxx>
> ---
>  INSTALL |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/INSTALL b/INSTALL
> index 6afbd90..11c388b 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -19,7 +19,8 @@ insmod btrfs.ko
>  
>  The Btrfs utility programs require libuuid to build.  This can be found
>  in the e2fsprogs sources, and is usually available as libuuid or
> -e2fsprogs-devel from various distros.
> +e2fsprogs-devel from various distros.  The other dependency is libattr
> +(libattr1-dev in Debian-based distros).
>  
>  Building the utilities is just make ; make install.  The programs go
>  into /usr/local/bin.  The mains commands available are:
> -- 
> 1.7.6.3

Scratch that, it seems it's indeed not needed.  The thing is that every
time a set up a new test machine I have to install libattr1-dev, but I
never looked into it in detail.

So libattr1-dev is needed because mkfs includes attr/xattr.h to be able
to create FS from image with extended attributes.  I think it's safe to
change attr/xattr.h include to sys/xattr.h and thus get rid of this
build dependency.  (attr/xattr.h seems to be there for compatibility
with SGI IRIX)

I built mkfs with sys/xattr.h and created FS from directory containing
files with xattrs, it worked.

Thanks,

		Ilya
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux