On 01.11.2011 12:07, David Sterba wrote:
> On Tue, Nov 01, 2011 at 11:08:38AM +0100, Arne Jansen wrote:
>>> +/*
>>> + * Should be called with restripe_mutex held
>>> + */
>>> +int btrfs_restripe(struct restripe_control *rctl)
>>> +{
> ...
>>> + if (rctl->data.target & BTRFS_BLOCK_GROUP_DUP) {
>>> + printk(KERN_ERR "btrfs: dup for data is not allowed\n");
>>> + ret = -EINVAL;
>>> + goto out;
>>> + }
>>
>> It would be good to get these error messages somehow to the user,
>> or at least give the user a hint to look in dmesg.
>
> the restriper command ends with EINVAL which is in most cases returned
> as a result of the ioctl and progs counterpart will
>
> 1117 fprintf(stderr, "ERROR: error during restriping '%s' "
> 1118 "- %s\n", path, strerror(e));
> 1119 return 19;
>
> the hint should go there imho.
Though it would still be much nicer to get a proper error message to the
user directly.
>
>
> david
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
