Hi Josef,
On Mon, Oct 03, 2011 at 11:51:30PM +0200, David Sterba wrote:
> > --- a/fs/btrfs/super.c
> > +++ b/fs/btrfs/super.c
> > @@ -164,7 +164,7 @@ enum {
> > Opt_notreelog, Opt_ratio, Opt_flushoncommit, Opt_discard,
> > Opt_space_cache, Opt_clear_cache, Opt_user_subvol_rm_allowed,
> > Opt_enospc_debug, Opt_subvolrootid, Opt_defrag,
> > - Opt_inode_cache, Opt_err,
> > + Opt_inode_cache, Opt_no_space_cache, Opt_err,
>
> how about _not_ adding a new optoin and just extend the existing one:
>
> space_cache=off
Thanks for fixing the patch in your tree, however adding the 'no' prefix
seems more in line with other options and their disabling counterparts
(like ssd/nossd, more to come).
I would have asked you to consider changing it to 'nospace_cache' and
refreshing the patch, but it's deep inside your for-chris branch so I'll
rather send patch if there aren't objections voiced.
thanks,
david
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
