On Wed, Oct 12, 2011 at 11:50 PM, Mitch Harder <mitch.harder@xxxxxxxxxxxxxxxx> wrote: > On Wed, Oct 12, 2011 at 10:22 AM, Fajar A. Nugraha <list@xxxxxxxxx> wrote: >> I noticed that "btrfs subvolume snapshot" is now broken. It keeps on >> saying "Invalid arguments for subvolume snapshot". >> >> Further checking shows it's caused by >> >> commit f71210f87e0c684d8c76dfa2e19ea86256fc3d1f >> Author: Andreas Philipp <philipp.andreas@xxxxxxxxx> >> Date: Thu Aug 11 08:45:40 2011 +0200 >> >> check number of args for btrfs sub snap correctly > > It looks like there have been two patches that touched on this issue, > and they conflicted with one-another. > > Arne Jansen's "btrfs-progs: add qgroup commands" patch added a "optind > = 1;" line, where optind was defaulting to zero before. > > This conflicted with Hugo Mills"fix incorrect argument checking for > "btrfs sub snap -r"" patch. > > So it looks like "(argc - optind != 2)" is now correct. > Ah, that explains it then. Thanks. -- Fajar -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
