On Wed, Oct 12, 2011 at 10:22 AM, Fajar A. Nugraha <list@xxxxxxxxx> wrote:
> On Wed, Oct 12, 2011 at 7:34 PM, Hugo Mills <hugo@xxxxxxxxxxxxx> wrote:
>> Fixes or updated patches for any problems you may find are
>> welcomed, of course.
>
> I noticed that "btrfs subvolume snapshot" is now broken. It keeps on
> saying "Invalid arguments for subvolume snapshot".
>
> Further checking shows it's caused by
>
> commit f71210f87e0c684d8c76dfa2e19ea86256fc3d1f
> Author: Andreas Philipp <philipp.andreas@xxxxxxxxx>
> Date: Thu Aug 11 08:45:40 2011 +0200
>
> check number of args for btrfs sub snap correctly
>
> Check whether there are the right number of arguments (exatly 2 without
> the flag -r) in the subcommand handler for the btrfs subvolume snapshot
> command.
>
>
>
> changing
>
> if (argc - optind != 3) {
>
> back to
>
> if (argc - optind != 2) {
>
> makes the snapshot creation works again, tested both with and without
> "-r" on Ubuntu Natty + kernel 3.1.0-rc9. I reverted that commit for my
> system for now.
>
It looks like there have been two patches that touched on this issue,
and they conflicted with one-another.
Arne Jansen's "btrfs-progs: add qgroup commands" patch added a "optind
= 1;" line, where optind was defaulting to zero before.
This conflicted with Hugo Mills"fix incorrect argument checking for
"btrfs sub snap -r"" patch.
So it looks like "(argc - optind != 2)" is now correct.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
