Excerpts from Tsutomu Itoh's message of 2011-07-18 20:07:44 -0400: > Hi, Mark, > > (2011/07/19 7:09), Mark Fasheh wrote: > > On Fri, Jul 15, 2011 at 12:04:46PM +0900, Tsutomu Itoh wrote: > >> (2011/07/15 7:15), Mark Fasheh wrote: > >>> In addition to properly handling allocation failure from btrfs_alloc_path, I > >>> also fixed up the kzalloc error handling code immediately below it. > >> > >> Need not you correct the caller of btrfs_drop_snapshot()? > > > > Hmm, I don't think so - the only two callers of btrfs_drop_snapshot() are merge_reloc_roots() and > > btrfs_clean_old_snapshots(). Both of which currently ignore the return code. > > If you think so, I think that you should change the type of btrfs_drop_snapshot() > into 'void'. In both of these cases we should be forcing the FS readonly instead. -chris -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
