On 08.07.2011 01:19, Goffredo Baroncelli wrote: > On 07/07/2011 06:01 PM, Jan Schmidt wrote: >> The kernel patch series just sent (Subject: "Btrfs: scrub: print path to >> corrupted files and trigger nodatasum fixup") introduces two new ioctls to >> do in-kernel filesystem path construction. This series provides the >> corresponding userspace changes, adding two new commands to the btrfs utility: > > Which is the aim of these commands ? It seems more a "debug" utilities > than a standard command. If so, these commands may be put under a new > group called "debug" or "test" or whichever we decided to use. But, > please, highlight the fact that these commands aren't for a general use. Well, in my opinion, they are. Finding files for an inode is not that exotic, is it? The command to find files for logical addresses is useful until each and every error message in the kernel log does that resolving itself. Currently, we log logical addresses everywhere. Once that's changed, this one becomes more like a debug command, I agree. > I suggest to use > > btrfs debug resolve ... > > Or better > > btrfs inspect resolve ... I don't give much in command names (I admit they should make sense), I'm happy to insert an "inspect" there. Although "btrfs inspect resolve inode" sounds strange to me. Any other opinions? I suggest we'd better do the naming process in #btrfs. >> >> -- >> btrfs resolve inode [-v] <inode> <path> >> resolves an <inode> to all filesystem paths local to the fs mounted >> at <path>. >> -v print count of returned and missed paths >> >> btrfs resolve logical [-v] [-P] <logical> <path> >> resolves a <logical> address to all filesystem paths in the file >> system mounted at <path> and all its subvolumes. >> -v print count of returned and missed inode/offset/root >> triples >> -P do not resolve the path but stop after finding all >> inodes at this logical address and print them instead >> -- >> >> These patches are based on Hugo's current integration branch. >> >> Please try them out and report bugs here. I'll send an update to the manpages >> later. > > Please update the man pages at the same time of the code. Develop the > man page coupled with the code may help to design a "good interface" > (from an user point of view) and to explain better the aim of the new > command. Agreed. Next version will come with man pages. -Jan -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
