Re: [PATCH] Btrfs: set no_trans_join after trying to expand the transaction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/15/2011 10:36 AM, Jim Schutt wrote:
> 
> Josef Bacik wrote:
>> We can lockup if we try to allow new writers join the transaction and
>> we have
>> flushoncommit set or have a pending snapshot.  This is because we set
>> no_trans_join and then loop around and try to wait for ordered extents
>> again.
>> The problem is the ordered endio stuff needs to join the transaction,
>> which it
>> can't do because no_trans_join is set.  So instead wait until after
>> this loop to
>> set no_trans_join and then make sure to wait for num_writers == 1 in case
>> anybody got started in between us exiting the loop and setting
>> no_trans_join.
>> This could easily be reproduced by mounting -o flushoncommit and
>> running xfstest
>> 13.  It cannot be reproduced with this patch.  Thanks,
> 
> FWIW, this version of the patch works fine for me
> as well.
> 

Great, thanks for testing.

Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux