On 06/12/2011 09:52 PM, Li Zefan wrote: > Josef Bacik wrote: >> We used to store the checksums of the space cache directly in the space cache, >> however that doesn't work out too well if we have more space than we can fit the >> checksums into the first page. So instead use the normal checksumming >> infrastructure. There were problems with doing this originally but those >> problems don't exist now so this works out fine. Thanks, >> > > This looks great, so I'll drop my patch that extends the original code to > allow more than 1 crc page. > > one comment below: > > ... >> @@ -879,11 +802,7 @@ int __btrfs_write_out_cache(struct btrfs_root *root, struct inode *inode, >> >> ret = 1; >> >> -out_free: >> - kfree(checksums); >> - kfree(pages); >> - > > leak memory by removing kfree(pages). Ah right good catch, I'll fix that up, thanks, Josef -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
