On Wed, Jul 22, 2020 at 7:33 AM David Sterba <dsterba@xxxxxxx> wrote: > > On Wed, Jul 22, 2020 at 06:58:39AM +0800, Qu Wenruo wrote: > > >> Thus casting both would definitely be right, without the need to refer > > >> to the complex rule book, thus save the reviewer several minutes. > > > > > > The opposite, if you send me code that's not following known schemes or > > > idiomatic schemes I'll be highly suspicious and looking for the reasons > > > why it's that way and making sure it's correct costs way more time. > > > > > OK, then would you please remove one casting at merge time, or do I need > > to resend? > > Yeah, I fix such things routinely no need to resend. I have a report[1] that seems to look like this patch solves it, is that correct? [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1851674#c7 -- 真実はいつも一つ！/ Always, there's only one truth!
