On Thu, Jul 02, 2020 at 08:14:34AM +0800, Qu Wenruo wrote: > This reverts commit a514d63882c3d2063b21b865447266ebcb18b04c. > > Since we have the ability to retry qgroup reservation, and do qgroup > space flushing, there is no need for the BTRFS_FS_NEED_ASYNC_COMMIT > mechanism anymore. > > Just revert that commit to make the code a little simpler. Interestingly, the same comment from https://lore.kernel.org/linux-btrfs/20180629114629.GO2287@xxxxxxxxxxxxx/ applies to your patch sans the references to the other patch: " I do not recommend to do a revert here. Even if a patch reverts functionality because it's not needed anymore, then it's a "forward" change. There are also other changes that may affect the behaviour and in this case it's 47dba17171a76ea2a2a71 that removes rcu barrier, so the patch has to be put into the context of current code. The commit is almost 2 years old, the idea of reverts is IMHO more to provide an easy way do a small step back during one devlopment cycle when the moving parts are still in sight. Back then the commit fixed a deadlock, a revert here would read as 'ok, we want the deadlock back'. So, the code is ok. The subject needs to drop the word 'revert' and changelg maybe mention a few more references why the logic is not needed anymore. "
