On Mon, Jun 22, 2020 at 11:20:11AM -0500, Goldwyn Rodrigues wrote: > From: Goldwyn Rodrigues <rgoldwyn@xxxxxxxx> > > We don't need the inode locked to check for the error bit. Move the > check early. This lacks explanation why it's not needed. I've checked history of the code and it seems the error state flags has been after all other checks since long, starting in acce952b0263825d. But it's part of a bigger patch and is not specific about this call site. If something checks state and changes the location, we need to make sure the state is not affected by code between the old and new location.
