On Mon, Jun 22, 2020 at 06:19:39PM +0300, Nikolay Borisov wrote: > > I've looked at the result and it could really use the comments from > > 190f0b76ca49 where the definitions switch the output and some whitespace > > fixups in the new definitions. > > > > Not all enums are converted, just search for use of __print_symbolic > > inside the show_TYPE helpers (eg. show_ref_action, show_ref_type), > > please add them too. Thanks. > > I beg you to differ: > > show_ref_action/show_ref_type/__show_root_type/__show_map_type/ - those > are defined and they are OK as is, because defines don't emit separate > symbols. However, when/if in the future those defines are switched to > enums then the respective tracepoint code should be converted to using > the EM macros as well. I see, it's define vs enum.
