On 12/6/20 11:39 pm, David Sterba wrote:
On Fri, Jun 12, 2020 at 06:56:06PM +0800, Anand Jain wrote:
Add btrfs(8) global --verbose and --quiet command options to show
verbose or no output from the sub-commands.
By introducing global a %bconf::verbose memeber to transpire the same
down to the sub-command.
Further the added helper function pr_verbose() helps to logs the verbose
messages, based on the state of the %bconf::verbose. And further HELPINFO_
defines are provides for the usage.
Suggested-by: David Sterba <dsterba@xxxxxxxx>
Signed-off-by: Anand Jain <anand.jain@xxxxxxxxxx>
---
v3:
Add define MUST_LOG
Add comment about the argument %level in the function pr_verbose()
Now you've created quite some chaos here, why didn't you just send v3 as
a standalone patchset? Replies to individual patches works for small
fixups but not as a whole new iteration.
The second part now depends on this v3 that has the MUST_LOG define
burried in patch 2/16, while it should have been one extra patch to the
second part and we'd be done with that. I'll sort it out somehow but ...
Yeah, standalone patch would have been simpler. It was painful at my
end too. Sorry about that.
On a different topic. I checked with you before - by legacy send.c and
receive.c use stderr for verbosity. Is it a regression to change these
to stdout now?
