From: Goldwyn Rodrigues <rgoldwyn@xxxxxxxx>
Filesystems such as btrfs are unable to guarantee page invalidation
because extents could be locked because of an ongoing I/O. This happens
even though a filemap_write_and_wait() has been called because
btrfs locks extents in a separate cleanup thread until all ordered
extents in range have performed the tree changes.
Return zero in case a page cache invalidation is unsuccessful so
filesystems can fallback to buffered I/O.
This takes care of the following invalidation warning during btrfs
mixed buffered and direct I/O using iomap_dio_rw():
Page cache invalidation failure on direct I/O. Possible data
corruption due to collision with buffered I/O!
This is similar to the behavior of generic_file_direct_write().
Signed-off-by: Goldwyn Rodrigues <rgoldwyn@xxxxxxxx>
---
fs/iomap/direct-io.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
index e4addfc58107..215315be6233 100644
--- a/fs/iomap/direct-io.c
+++ b/fs/iomap/direct-io.c
@@ -483,9 +483,15 @@ iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter,
*/
ret = invalidate_inode_pages2_range(mapping,
pos >> PAGE_SHIFT, end >> PAGE_SHIFT);
- if (ret)
- dio_warn_stale_pagecache(iocb->ki_filp);
- ret = 0;
+ /*
+ * If a page can not be invalidated, return 0 to fall back
+ * to buffered write.
+ */
+ if (ret) {
+ if (ret == -EBUSY)
+ ret = 0;
+ goto out_free_dio;
+ }
if (iov_iter_rw(iter) == WRITE && !wait_for_completion &&
!inode->i_sb->s_dio_done_wq) {
--
2.25.0
