On Wed, May 27, 2020 at 05:12:25PM +0900, Johannes Thumshirn wrote: > The 'out' label in find_first_block_group() does not do anything in terms > of cleanup. > > It is better to directly return 'ret' instead of jumping to out to not > confuse readers. Additionally there is no need to initialize ret with 0. https://www.kernel.org/doc/html/latest/process/coding-style.html#centralized-exiting-of-functions
