Re: [PATCH] btrfs: Open code key_search

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 27.05.20 г. 15:25 ч., Johannes Thumshirn wrote:
> On 27/05/2020 12:11, Nikolay Borisov wrote:
> 
> Looks good,
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>
> 
> One nit though:
> 
>> +			ret = btrfs_bin_search(b, key, &slot);
>> +			prev_cmp = ret;
> 
> I actually find:
> 			ret = prev_cmp = brtfs_bin_search(b, key, &slot);
> 
> a bit more readable in this case.
> 

True, AFAIK David is not a fan of multiple assignments on the same line ;)



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux