Re: [PATCH 1/3] btrfs: remove pointless out label in find_first_block_group

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 26.05.20 г. 17:21 ч., Johannes Thumshirn wrote:
> The 'out' label in find_first_block_group() does not do anything in terms
> of cleanup.
> 
> It is better to directly return 'ret' instead of jumping to out to not
> confuse readers. Additionally there is no need to initialize ret with 0.
> 
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>

I personally prefer returning fast aka the way you've done it but dunno
if David is a fan of this. In any case:


Reviewed-by: Nikolay Borisov <nborisov@xxxxxxxx>



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux