Re: [PATCH] btrfs: quasi-round-robin for chunk allocation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Apr 11, 2011 at 01:46:33PM -0400, Chris Mason wrote:
> My big complaint about this patch is that it is a feature fix mixed in
> with a huge cleanup.  It's hard to differentiate between the two.  Could
> you please separate it out so we can review them independently?

I agree that changes should go separated by cleanups and fixes, but
after going through the main patch, I do not see a way how to do it. New
version does not leave much from the previous code and structuring, and
the allocation strategy looks clear from the new version.

The comments I've posted today to V3 contain pure cleanups, yes they
could be separated, but there are very few of them and touch the new
version in some cases anyway. I do not see much sense to send them
separately.


HTH,
david
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux