On Fri, Apr 17, 2020 at 05:53:49PM +0000, Johannes Thumshirn wrote:
> On 16/04/2020 23:47, Omar Sandoval wrote:
> [...]
> > +static struct btrfs_dio_private *btrfs_create_dio_private(struct bio *dio_bio,
> > + struct inode *inode,
> > + loff_t file_offset)
> > {
> > - struct inode *inode = dip->inode;
> > + const bool write = (bio_op(dio_bio) == REQ_OP_WRITE);
>
> Nit: I think the braces aren't needed here.
For readability I prefer to keep them, it makes the operator precedence
obvious.
