On 16/04/2020 23:47, Omar Sandoval wrote:
[...]
> +static struct btrfs_dio_private *btrfs_create_dio_private(struct bio *dio_bio,
> + struct inode *inode,
> + loff_t file_offset)
> {
> - struct inode *inode = dip->inode;
> + const bool write = (bio_op(dio_bio) == REQ_OP_WRITE);
Nit: I think the braces aren't needed here.
[...]
> +static void btrfs_submit_direct(struct bio *dio_bio, struct inode *inode,
> + loff_t file_offset)
> +{
> + const bool write = (bio_op(dio_bio) == REQ_OP_WRITE);
Same here
Anyways:
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>
