On 2020/4/17 下午5:03, Nikolay Borisov wrote:
>
>
> On 17.04.20 г. 10:08 ч., Qu Wenruo wrote:
>> We can easily get the level from @eb parameter, thus the level is not
>> needed.
>>
>> This is inspired by the work of Marek in U-boot.
>>
>> Cc: Marek Behun <marek.behun@xxxxxx>
>> Signed-off-by: Qu Wenruo <wqu@xxxxxxxx>
>
> Reviewed-by: Nikolay Borisov <nborisov@xxxxxxxx>
>
> <snip>
>
>> @@ -2953,8 +2952,7 @@ static int do_relocation(struct btrfs_trans_handle *trans,
>> slot = path->slots[upper->level];
>> btrfs_release_path(path);
>> } else {
>> - ret = btrfs_bin_search(upper->eb, key, upper->level,
>> - &slot);
>> + ret = btrfs_bin_search(upper->eb, key, &slot);
>
> nit: By the same token why does btrfs_backref_node need an explicit
> level member if its level is always equal to that of eb->level ?
I guess because btrfs_backref_node::eb is not always ensured to exist.
Thanks,
Qu
>
> <snip>
>>
