Re: [PATCH] btrfs: Remove the duplicated @level parameter for btrfs_bin_search()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 17.04.20 г. 10:08 ч., Qu Wenruo wrote:
> We can easily get the level from @eb parameter, thus the level is not
> needed.
> 
> This is inspired by the work of Marek in U-boot.
> 
> Cc: Marek Behun <marek.behun@xxxxxx>
> Signed-off-by: Qu Wenruo <wqu@xxxxxxxx>

Reviewed-by: Nikolay Borisov <nborisov@xxxxxxxx>

<snip>

> @@ -2953,8 +2952,7 @@ static int do_relocation(struct btrfs_trans_handle *trans,
>  			slot = path->slots[upper->level];
>  			btrfs_release_path(path);
>  		} else {
> -			ret = btrfs_bin_search(upper->eb, key, upper->level,
> -					       &slot);
> +			ret = btrfs_bin_search(upper->eb, key, &slot);

nit: By the same token why does btrfs_backref_node need an explicit
level member if its level is always equal to that of eb->level ?

<snip>
> 



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux