Re: [PATCH v4 2/2] btrfs: Reformat btrfs_tree.h comments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 15, 2020 at 04:41:13PM +0800, Qu Wenruo wrote:
> Since we're here, modify btrfs_tree.h to follow the latest comment
> style.
> 
> This involves:
> - Use upper case char for the first word
> - Use one line comment if possible
> - Add the ending dot if it's a sentence
> - Add more comment explaining the usage of each tree
> - Add key type/objectid/offset reference URL
> - Remove dead comment
> - Update the header define line to reflect the filename
> - Add newline to seperate long comment

Going through the file I think we could do more changes so the format
documentation is complete. I'd also reformat the defines so the name and
value are separated by a few tabs. My changes on top of your patch will
be in misc-next but the plan is to squash them in the end. It'll
probably take a few more passes so the style is consistent.



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux