Re: [PATCH] btrfs: Make btrfs_read_disk_super return struct btrfs_disk_super

[David Sterba <dsterba@xxxxxxx>]

On Wed, Apr 15, 2020 at 03:53:46PM +0300, Nikolay Borisov wrote:
> @@ -1337,7 +1336,8 @@ struct btrfs_device *btrfs_scan_one_device(const char *path, fmode_t flags,
>  	if (IS_ERR(bdev))
>  		return ERR_CAST(bdev);
>  
> -	if (btrfs_read_disk_super(bdev, bytenr, &page, &disk_super)) {
> +	disk_super = btrfs_read_disk_super(bdev, bytenr);
> +	if (IS_ERR(disk_super)) {
>  		device = ERR_PTR(-EINVAL);

This should forward the error value from btrfs_read_disk_super, like

		device = disk_super;