On Tue, Feb 25, 2020 at 03:05:53PM +0100, David Sterba wrote:
> Deleting a subvolume on a full filesystem leads to ENOSPC followed by a
> forced read-only. This is not a transaction abort and the filesystem is
> otherwise ok, so the error should be just propagated.
>
> This is caused by unnecessary call to btrfs_handle_fs_error for almost
> all errors, except EAGAIN. This does not make sense as the standard
> transaction abort mechanism is in btrfs_drop_snapshot so all relevant
> failures are handled.
>
> Originally in commit cb1b69f4508a ("Btrfs: forced readonly when
> btrfs_drop_snapshot() fails") there was no return value at all, so the
> btrfs_std_error made some sense but once the error handling and
> propagation has been we don't need it.
>
> Signed-off-by: David Sterba <dsterba@xxxxxxxx>
I'm hitting the ENOSPC and now also EINTR after the fast balance cancel
patches so this is needed. If anybody has still concerns, please let me
know, patch goes to misc-next.
