Excerpts from Daniel J Blueman's message of 2011-05-10 01:42:45 -0400:
> Hi Chris,
>
> On 4 May 2011 22:40, Josef Bacik <josef@xxxxxxxxxx> wrote:
> > On 05/03/2011 10:54 PM, Daniel J Blueman wrote:
> >>
> >> If posix_acl_from_xattr() returns an error code, a negative address is
> >> dereferenced causing an oops; fix by checking for an error code first.
> >>
> >> Typo fixed; too much late-night coding.
> >>
> >> Signed-off-by: Daniel J Blueman<daniel.blueman@xxxxxxxxx>
> >> ---
> >> Âfs/btrfs/acl.c | Â Â5 +++--
> >> Â1 files changed, 3 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/fs/btrfs/acl.c b/fs/btrfs/acl.c
> >> index 5d505aa..44ea5b9 100644
> >> --- a/fs/btrfs/acl.c
> >> +++ b/fs/btrfs/acl.c
> >> @@ -178,12 +178,13 @@ static int btrfs_xattr_acl_set(struct dentry
> >> *dentry, const char *name,
> >>
> >> Â Â Â Âif (value) {
> >> Â Â Â Â Â Â Â Âacl = posix_acl_from_xattr(value, size);
> >> + Â Â Â Â Â Â Â if (IS_ERR(acl))
> >> + Â Â Â Â Â Â Â Â Â Â Â return PTR_ERR(acl);
> >> +
> >> Â Â Â Â Â Â Â Âif (acl) {
> >> Â Â Â Â Â Â Â Â Â Â Â Âret = posix_acl_valid(acl);
> >> Â Â Â Â Â Â Â Â Â Â Â Âif (ret)
> >> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âgoto out;
> >> - Â Â Â Â Â Â Â } else if (IS_ERR(acl)) {
> >> - Â Â Â Â Â Â Â Â Â Â Â return PTR_ERR(acl);
> >> Â Â Â Â Â Â Â Â}
> >> Â Â Â Â}
> >>
> >
> > Actually pulled this down and compiled it this time to make sure it worked.
> > ÂYou can add
> >
> > Reviewed-by: Josef Bacik <josef@xxxxxxxxxx>
>
> Will this fix go upstream for the final 2.6.39, now that the last -rc
> is already out? I hit it in two independent cases when rebooting after
> other kernel crashes.
Yes, I have one other patch to from Li Zefan that I will send along.
-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
