On 7.04.20 г. 17:14 ч., Filipe Manana wrote: > On Tue, Apr 7, 2020 at 12:32 PM Nikolay Borisov <nborisov@xxxxxxxx> wrote: >> >> >> >> On 7.04.20 г. 13:38 ч., fdmanana@xxxxxxxxxx wrote: >>> From: Filipe Manana <fdmanana@xxxxxxxx> >>> >>> The reclaim_size counter of a space_info object is unsigned. So its value >>> can never be negative, it's pointless to have an assertion that checks >>> its value is >= 0, therefore remove it. >>> >>> Signed-off-by: Filipe Manana <fdmanana@xxxxxxxx> >> >> True, >> >> Reviewed-by: Nikolay Borisov <nborisov@xxxxxxxx> I guess this could be >> squashed. > > Despite being a trivial and small change, I don't think it should be > squashed into the previous patch, as it's not part of the bug fix > regarding the counter leak. > Different changes and unrelated changes should be separate patches. I meant to say squashed into the original commit that introduced the assert but it seems it has already been merged into master so yeah, it will go as it is.
