On 7.04.20 г. 13:38 ч., fdmanana@xxxxxxxxxx wrote:
> From: Filipe Manana <fdmanana@xxxxxxxx>
>
> The reclaim_size counter of a space_info object is unsigned. So its value
> can never be negative, it's pointless to have an assertion that checks
> its value is >= 0, therefore remove it.
>
> Signed-off-by: Filipe Manana <fdmanana@xxxxxxxx>
True,
Reviewed-by: Nikolay Borisov <nborisov@xxxxxxxx> I guess this could be
squashed.
> ---
> fs/btrfs/space-info.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/btrfs/space-info.c b/fs/btrfs/space-info.c
> index ff17a4420358..88d7dea215ff 100644
> --- a/fs/btrfs/space-info.c
> +++ b/fs/btrfs/space-info.c
> @@ -1198,7 +1198,6 @@ static int __reserve_metadata_bytes(struct btrfs_fs_info *fs_info,
> * the list and we will do our own flushing further down.
> */
> if (ret && flush != BTRFS_RESERVE_NO_FLUSH) {
> - ASSERT(space_info->reclaim_size >= 0);
> ticket.bytes = orig_bytes;
> ticket.error = 0;
> space_info->reclaim_size += ticket.bytes;
>
