Re: [PATCH v2] btrfs-progs: add warning for mixed profiles filesystem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 31/03/2020 23:05, Zygo Blaxell wrote:
> On Tue, Mar 31, 2020 at 10:46:17PM +0100, Graham Cobb wrote:
>> On 31/03/2020 20:10, Goffredo Baroncelli wrote:
>>> WARNING: ------------------------------------------------------
>>> WARNING: Detection of multiple profiles for a block group type:
>>> WARNING:
>>> WARNING: * DATA ->          [raid1c3, single]
>>> WARNING: * METADATA ->      [raid1, single]
>>> WARNING:
>>> WARNING: Please consider using 'btrfs balance ...' commands set
>>> WARNING: to solve this issue.
>>> WARNING: ------------------------------------------------------
>>
...
>> I would suggest a more compact layout and factual tone. Something like:
>>
>> Caution: This filesystem has multiple profiles for a block group type
>> so new block groups will have unpredictable profiles.
>>  * DATA ->          [raid1c3, single]
>>  * METADATA ->      [raid1, single]
>> Use of 'btrfs balance' is recommended as soon as possible to move all
>> blocks to a single profile for each of data and metadata.
> 
> How about a one-liner:
> 
> 	NOTE: Multiple profiles detected.  See 'man btrfs-filesystem'.
> 
> with a section in the btrfs-filesystem man page giving a detailed
> description of the problem and examples of possible remedies.
> 

Even better. I have just realised that the information in the "* DATA ->
         [raid1c3, single]" part of the message is, of course, available
in the rest of the output so doesn't need to be included.

I would suggest including a very brief description of the problem, in
order to prompt people to actually take action. How about:

Caution: Multiple profiles detected which will cause unpredictable
profiles for new data.  See 'man btrfs-filesystem' for recommendations.




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux